![]() |
||||
|
|
||||
[Chameleon-dev] [Bug 92] [Chameleon] - preparation for 1.1 betabugzilla-daemon@www.maptools.org bugzilla-daemon@www.maptools.orgTue, 4 Nov 2003 17:47:05 -0500
|
||||
http://www.maptools.org/bugzilla/show_bug.cgi?id=92
------- Additional Comments From assefa@dmsolutions.ca 2003-11-04 17:47 -------
Here are some hints that can help for the code review :
- limit the number of people to 3 to four (the code owner + couple of people)
- target time for the meeting should be 1h or less
- code owner should be responsable of preparing (printing the code to review
with line numbers) and give it to the others (at least a couple of days before.
- we could setup 1 code review per week at the same time (maybe a wiki page
indicating the code reviewed and the persons attending). Every body should
atleast be a review and a reviwer at least once. (People not on the review list
but are interested could add themselves to the list)
- the sceduling should be a growing list and should be updated every time a
new code (or at least a critical peice of code) is added.
- the main point is to determine what the review should include. Here are some
hints :
* optimization
* errors/potential errors
* design flaws
* code convention
- tracking of the code review : this could be done in at least 2 ways :
* if there is not much to change, It could just be the responsability of the
review to take notes and update the code
* if there are a lot of things, this could be entered as a bug with details
of changes.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
This archive was generated by Pipermail. |
MapTools.org -- Hosted by DM Solutions Group |