[Chameleon-dev] [Bug 107] New: [TemplateParser] implement code review comments
Wed, 12 Nov 2003 14:58:31 -0500

           Summary: [TemplateParser] implement code review comments
           Product: Chameleon
           Version: 1.1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Core

Code Review held 2003-11-12 for TemplateParser.php

add mnElements member variable
modify constructor to take pattern
modify constructor to take ref to object providing GetTemplate()
add comment for constructor
add @return comment to Parse
modify LoadTemplate -> SetTemplate
modify Parse to remove CWC-specific stuff (use moTemplateLoader->GetTemplate())
modify Parse to set mnElements at the end
modify ParseCallback to use array_push rather than count()
remove replace none mode from ProcessPatternReplacement (i.e. index 0 is the
first element instead of 1)
replace GLOBALS with member variables in preg_callback
change name of preg_callback to ProcessPatternReplacementCallback
change NumElements() to use member variable
add GetTemplate method as per documentation
add class comment for CWCTemplateParser
change CWCTemplateParser constructor to accept object, pass object and pattern
to parent constructor

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

This archive was generated by Pipermail.