[Chameleon-dev] [Bug 109] [Chameleon] Code Review - WidgetManager.php
Thu, 13 Nov 2003 11:37:45 -0500 changed:

           What    |Removed                     |Added
                 CC|                            |chameleon-
                   |                            |
         AssignedTo|chameleon-                  |
                   |      |
   Target Milestone|---                         |1.1 beta release

------- Additional Comments From  2003-11-13 11:37 -------
WidgetManager.php version 1.25 2003-10-31

- expand class comment to include better explanation of what the widget manager
actually does, include example, clarify that this is internal to Chameleon.
- add comments to class variables
- constructor needs comments
- investigate if foreach is faster than for?  If not, replace foreach with for.
- change " to '
- remove pre-registration of widgets from constructor, only build widget
directory array.
- in LoadWidget, test to see if the widget is loaded and if not, test for widget
in each directory, load it, and register that it is loaded.  Use class_exists()
- LoadWidget needs function comment
- is PreloadWidgets required?
- missing function description for CreateWidgetUsingTag, remove @param szContent
- add brackets to else on line 153
- line 127 - remove if, not required
- replace ExtractClassName with preg match?  Make sure that type="..." has a
space at the beginning. (Julien)
- check eval to see if it is causing a time problem (in CreateWidgetUsingTag)
- remove lines 155-159 (handled in Widget.php)

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.

This archive was generated by Pipermail.