[Chameleon-dev] [Bug 109] [Chameleon] Code Review - WidgetManager.php

[bugzilla-daemon@www.maptools.org]

http://www.maptools.org/bugzilla/show_bug.cgi?id=109





------- Additional Comments From spencer@dmsolutions.ca  2003-11-13 23:43 -------
class comment done
class variable comments done
constructor comments added
removed need for loop entirely
changed " for ' where practical, still require a regexp for finding widget type
to remove last one
removed pre-registration of widgets
modified LoadWidget to use class_exists and include in much tighter loop
added function comment to LoadWidget
removed PreloadWidgets
added function comment to CreateWidgetUsingTag, removed szContext
bracketed 'else'
eval is not a performance hit (AFAI can tell)
removed visibility code

outstanding is the preg_match function for getting the type name out.

BTW, include does not seem much faster than include_once ... this module is
still performance bound by the number/size of files it has to include rather
than any other factor.  For a reasonably complete template with 50-60 widgets,
this takes about 115 ms.



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.