[Chameleon-dev] [Bug 47] [Chameleon] Form parameters should be case-insensitive

[bugzilla-daemon@www.maptools.org]

http://www.maptools.org/bugzilla/show_bug.cgi?id=47





------- Additional Comments From spencer@dmsolutions.ca  2003-09-11 21:06 -------
As far as I am aware, everything is explicitly converted to uppercase now,
everything in Chameleon was designed to expect uppercase internally but to
accept any case coming in.  I can think of a couple of exceptions, of course,
but they should be considered bugs or improper implementation.

This is not required, just a choice that was made to simplify the code (less
case-specific exceptions).  

The rationale is not strong, except that it seems to me that a lot of tools
(used to) generate tag names and parameters in uppercase, and stuff in uppercase
is more obvious.

I doubt picking lowercase will change anything, except cause more work and
potentially more bugs in existing code while trying to convert it.  Everything
either has to be explicitly converted or have multiple case-specific checks.

There is a getvalue method in widget that was intended for this purpose, it went
out of favour when I tried to do some optimizing.  Accessing values directly
instead of through a function call resulted some fairly significant savings. 
Removing the getvalue code resulted in the uppercase convention.

I would be interested in the details of any bugs that resulted in this
discussion.  Perhaps Sacha/Julien can provide details?

I am hesitant to make this change without a better understanding of the issues.



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.