MapTools.org

[Chameleon-dev] [Bug 47] [Chameleon] Form parameters should be case-insensitive

bugzilla-daemon@www.maptools.org bugzilla-daemon@www.maptools.org
Thu, 18 Sep 2003 17:53:43 -0400
http://www.maptools.org/bugzilla/show_bug.cgi?id=47





------- Additional Comments From spencer@dmsolutions.ca  2003-09-18 17:53 -------
just to follow up on this.  I was mistaken, it is not the form parameters that
are explicitly upper case, it is all the widget attributes.  The form parameters
are left in whatever state the widget or user put them in.  I believe from the
discussions that I had with Sacha and Daniel that the problem was with the
session id provided by PHP, it is placed in the form with a lower case name
(sid), whereas the _convention_ has been to use uppercase form names in the
widgets.  I think at least one widget does not use this convention (Language)
but that should be considered a bug, as should other cases of the same thing.

This can be fairly easily confirmed by scanning the source code.  However, I am
not convinced that we need to uppercase all incoming form variables.  This
could, in my mind, add some confusion since a chameleon application consists of
both widgets and user code.  I think that it could be quite likely that the user
would use form values for his/her own purposes outside of Chameleon, and would
be perhaps confused if they ended up as uppercase all the time.

It could be a documentation issue.  I would prefer that it just be a convention
in CWC coding style.  Not sure what to do with this, though.  More
comments/feedback would help.




------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


This archive was generated by Pipermail.