[Chameleon-dev] [Bug 47] [Chameleon] Form parameters should be case-insensitive

bugzilla-daemon at www.maptools.org bugzilla-daemon@www.maptools.org
Thu Apr 8 16:49:28 EDT 2004


http://www.maptools.org/bugzilla/show_bug.cgi?id=47

pspencer@dmsolutions.ca changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



------- Additional Comments From pspencer@dmsolutions.ca  2004-04-08 11:49 -------
looking at this now.  This could involve modification to every single widget to
make it work but I will try to limit the changes as much as possible.

Currently form variables are accessed through two separate mechanisms:

1. each widget has a member variable called moURLArray which is a pointer to
either $_GET or $_POST.

2. there is an instance of the HttpFormVars class in the global Chameleon
application object that can be used to get at values case-insensitively.

Highest performance will be gained by using the array, but more flexibility will
be gained by switching all widgets to use HttpFormVars as well as case
insensitivity.  If we agree on the change then I will add a new member variable
to Widget called moURLObject and it will be a pointer to the HttpFormVars
instance kept in the global Chameleon app.

Then I will go through all widgets :( to replace references to moURLArray to
moURLObject.  Finally, I will remove moURLARray from Widget so any further code
that is developed will generate errors.

Then I will work on optimizing HttpFormVars for performance by forcing all the
array keys to uppercase and then using an uppercase version of the requested key
to find values.

Comments and suggestions welcome.




------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.



More information about the Chameleon-dev mailing list