[Chameleon-dev] [Bug 1101] ROICircle tool can get undefined values in coords parameter

bugzilla-daemon at bugzilla.maptools.org bugzilla-daemon at bugzilla.maptools.org
Mon Jun 27 07:02:48 EDT 2005


http://bugzilla.maptools.org/show_bug.cgi?id=1101





------- Additional Comments From bartvde at xs4all.nl  2005-06-27 07:02 -------
I fixed this, and also tested my fix with the ROI sample application. Now ROI's
can also drawn around near the edges of a map (and also overlapping the map rim).

Is it okay if I change this in CVS head Paul/Julien?

I changed the following 2 things:

1) cwc_roi.js

in CWCROIManager_Pix2Geo(x, y)

    //if (x >= 0 && x <= width &&
    //    y >= 0 && y <= height)
    if (x >= 0 && y >= 0)

removed the check that x and y have to be inside of the map. The result of this
function is also valid outside of the map, the extrapolation is valid outside of
the map.

2) ROIRenderer.php

function Geo2Pix:

Removed the following lines:
        //if ($nGeoPos < $dfGeoMin)
        //    $nGeoPos = $dfGeoMin;
        //if ($nGeoPos > $dfGeoMax)
        //    $nGeoPos = $dfGeoMax;



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


Please do NOT reply to this email, use the link above instead to 
login to bugzilla and submit your comment. Any email reply to this
address will be lost.


More information about the Chameleon-dev mailing list