[Geotiff] [MetaCRS] Motion: Adopt libgeotiff 1.4.2RC3 as 1.4.2 Release

[Even Rouault]

Le jeudi 18 août 2016 19:36:15, vous avez écrit :
> The error is
> 
> e:\jenkins\workspace\3rdparty-geotiff-matrix\arch\64\node_label\vc2015\proj
> ect\cpl_serv.h(45): fatal error C1083: Cannot open include file:
> 'strings.h': No such file or directory
> [E:\jenkins\workspace\project-build\win7-vc2015-64\geotiff\geotiff_library.
> vcxproj]
> 
> so the problem is that strings.h doesn't exist.
> 
> I don't understand how come #ifdef HAVE_STRINGS_H doesn't "work".  The
> cmake configuration reports
> 
> -- Looking for include file string.h
> -- Looking for include file string.h - found
> -- Looking for include file strings.h
> -- Looking for include file strings.h - not found
> 
> and the config file that cmake generates, geo_config.h, contains
> 
> /* #undef HAVE_STRINGS_H */

Super weird indeed. Don't you have a geo_config.h in the root directory that 
would have been put there by a previous nmake build attempt ? I see that 
makefile.vc copies geo_config.h.vc into geo_config.h and geo_config.h.vc 
(apparently wrongly) have #define HAVE_STRINGS_H 1

> 
> On 08/18/16 11:25, Even Rouault wrote:
> > Hum. for my education, could you post the error messages that result in
> > including both files? A sane system shouldn't error out... ah
> > Microsoft... strings.h according to standards is needed for strcasecmp
> > although i see posts that modern systems make those non deprecated
> > functions available through string.h. I will probably revert this change
> > then.  This was somewhat needed to fix a warning with cmake on Linux
> > about strcasecmp being not declared.
> > 
> > Le 18 août 2016 16:51, "Charles Karney" <charles.karney at sri.com
> > 
> > <mailto:charles.karney at sri.com>> a écrit :
> >> -1
> >> 
> >> Sorry I didn't see these release candidates until now.  For cmake
> >> builds under Windows (Visual Studio 2010 thru 2015), I need to revert
> >> cpl_serv.h to its previous state with this patch
> >> 
> >> diff --git a/cpl_serv.h b/cpl_serv.h
> >> index e33a73a..8f529c4 100644
> >> --- a/cpl_serv.h
> >> +++ b/cpl_serv.h
> >> @@ -41,7 +41,7 @@
> >> 
> >>  #ifdef HAVE_STRING_H
> >>  #  include <string.h>
> >>  #endif
> >> 
> >> -#ifdef HAVE_STRINGS_H
> >> +#if defined(HAVE_STRINGS_H) && !defined(HAVE_STRING_H)
> >> 
> >>  #  include <strings.h>
> >>  #endif
> >>  #ifdef HAVE_STDLIB_H
> >>  
> >>   --Charles
> >> 
> >> On 08/18/16 09:37, Even Rouault wrote:
> >>> Hi,
> >>> 
> >>> This is an official motion to the MetaCRS PSC to adopt libgeotiff
> > 
> > 1.4.2 RC3 as
> > 
> >>> the final release.
> >>> 
> >>> The changes since 1.4.1 are described in
> >>> https://svn.osgeo.org/metacrs/geotiff/tags/libgeotiff-1.4.2/ChangeLog .
> >>> 
> >>> A shortlog would be :
> >>>  * update to EPSG v8.9 database
> >>>  * cleanups and security fixes
> >>> 
> >>> Motion: Adopt libgeotiff 1.4.2RC3 as 1.4.2 Release
> >>> 
> >>>   http://download.osgeo.org/geotiff/libgeotiff/libgeotiff-1.4.2RC3.tar.
> >>>   gz
> >>>   http://download.osgeo.org/geotiff/libgeotiff/libgeotiff-1.4.2RC3.zip
> >>> 
> >>> Best regards,
> >>> 
> >>> Even

-- 
Spatialys - Geospatial professional services
http://www.spatialys.com