[Proj] MACRO modernization

[Even Rouault]

Le jeudi 19 mai 2016 16:12:39, Howard Butler a écrit :
> All,
> 
> I just wanted to make you aware of the significant effort that Thomas
> Knudsen and Kristian Evers have put in to modernize Proj.4's macros and
> codebase. Along the way, they've increased the code coverage 42%!
> 
> Three cheers to them!
> 
> https://github.com/OSGeo/proj.4/pull/373

This is an amazing work indeed !

As far as I can see the increased test coverage comes from pj_XXXXX_selftest() 
functions added in the file implemented each XXXXX projection method. It seems 
that by default those selftest functions are compiled, and if PJ_OMIT_SELFTEST 
is defined they are replaced by a stub.

For a "production" build, I'm wondering if we want the selftest to be compiled 
in the .so, so perhaps the logic should be reversed (and thus in Travis and 
other integration builds we would define PJ_INCLUDE_SELFTEST) ?

Size of libproj.so.11.0.0 (compiled with -O2 and stripped with -s)
* sdfe-refactor-macros--and-repair-generic-constructor-bug : 555440
* master : 379920

Even

-- 
Spatialys - Geospatial professional services
http://www.spatialys.com