[Proj] Review of proj.4 pull request
schwehr at gmail.com
Tue Sep 27 00:35:41 EST 2016
Try #2 to the proj mailing list now that I've actually confirmed my email
There is no rush on this. It was just a dead code complaint by a linter,
not a failure seen with actual code.
On Mon, Sep 26, 2016 at 6:16 PM, Nathan Wagner <nw at hydaspes.if.org> wrote:
> On Mon, Sep 26, 2016 at 06:42:58PM -0500, Howard Butler wrote:
> > > On Sep 26, 2016, at 4:04 PM, Kurt Schwehr <schwehr at gmail.com> wrote:
> > > The code says it was written by Nathan, so that would likely be the
> > > best one of you to give it a look over, but maybe someone else might
> > > know.
> > > Any chance one of you could take a look at pr 418? It's my first
> > > proj.4 patch... Am I missing anything with this? Was there a
> > > missing if?
> > > https://github.com/OSGeo/proj.4/pull/418
> > Please bring this up on the proj4 list, as I am happy to approve all
> > changesets that do not disrupt the tests -- for both good and bad ;)
> I'm looking into it. I'll have an answer later tonight. Three to four
> hours. Preliminary conclusion is that I had no idea what I was thinking
> when I wrote that code, and the code after the return is the right code,
> but maybe there's a bug or something that I missed. My tests don't
> exercise that code path.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Proj