[Proj] C++ coding practices w.r.t object ownership

[Even Rouault]

On dimanche 27 mai 2018 22:14:50 CEST Martin Desruisseaux wrote:
> I have one minor suggestion. In crs.hh file, there is the following
> comment in the GeodeticCRS class:
> 
>     // slight departure from standard. We can't override coordinateSystem()
> since // GeographicCRS::coordinateSystem() returns cs::EllipsoidalCS which
> is not // derived from GeodeticCS (GeodeticCS is a pseudo union) ...
>     const cs::GeodeticCS &geodeticCoordinateSystem() const;
> 
> I would suggest to not try too hard to represent verbatim the « union »
> constructs from ISO 19111, but rather focus on the intent.

Agreed. I wasn't really satisfied with this. A documentation note will do.

-- 
Spatialys - Geospatial professional services
http://www.spatialys.com