<div dir="ltr">I definitely agree with Greg: Autogenerated files have nothing to do under source control. They are not source files, after all.<div><br></div><div>/thomas</div></div><div class="gmail_extra"><br><div class="gmail_quote">2015-09-07 15:01 GMT+02:00 Greg Troxel <span dir="ltr"><<a href="mailto:gdt@ir.bbn.com" target="_blank">gdt@ir.bbn.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
Even Rouault <<a href="mailto:even.rouault@spatialys.com">even.rouault@spatialys.com</a>> writes:<br>
<br>
> And I've added also additional fixes : proj_def.dat was also missing in cmake,<br>
> and there were also other 4 files in nad/ that weren't in the EXTRA_DIST. I<br>
> realized that when adding a "self-consistency" check in .travis.yml: basically<br>
> I do a make install from the git checkout, then a make dist-all, build and<br>
> install (in another target dir) from the archive generated by make dist-all,<br>
> and compare the list of installed files (<br>
> <a href="https://github.com/OSGeo/proj.4/commit/ba3454ec0f9d1d33e165d0ace70f766c8283892e" rel="noreferrer" target="_blank">https://github.com/OSGeo/proj.4/commit/ba3454ec0f9d1d33e165d0ace70f766c8283892e</a><br>
> )<br>
<br>
</span>"make distcheck" is helpful. It produces a distfile, and then unpacks<br>
it and does a build with a different objdir and then runs make check in<br>
that.<br>
<span class=""><br>
> Another related topic is : what should be the policy with automake/autoconf<br>
> generated files in git :<br>
> - regenerate them and commit them each time they are modified. Advantage: the<br>
> export from git is always valid. Drawback: it is easy to forget regenerating<br>
> - regenerate them only just before release time (so travis build would need to<br>
> run ./autogen.sh)<br>
> - drop them from git completely ( that's what is suggested by<br>
> <a href="https://github.com/OSGeo/proj.4/pull/282" rel="noreferrer" target="_blank">https://github.com/OSGeo/proj.4/pull/282</a> )<br>
<br>
</span>my $0.02:<br>
<br>
* Definitely remove them, and tell people run autogen.sh to create them<br>
when building from git. This is the normal practice and works well.<br>
<br>
* Define that the only valid way to create a release tarball is "make<br>
dist". (I'm not sure what else you mean by "export from git".)<br>
<br>
(I maintain the proj package in pkgsrc, a multi-arch multi-OS packaging<br>
system.)<br>
<br>_______________________________________________<br>
Proj mailing list<br>
<a href="mailto:Proj@lists.maptools.org">Proj@lists.maptools.org</a><br>
<a href="http://lists.maptools.org/mailman/listinfo/proj" rel="noreferrer" target="_blank">http://lists.maptools.org/mailman/listinfo/proj</a><br></blockquote></div><br></div>