<div dir="ltr">Looks like a sensible thing to do, and your pseudocode/mnemonics are quite readable.<div><br></div><div>I think I have seen (and Google confirms) that TWO_OVER_PI is in common use for the 2/pi thing you call TWO_D_PI, but I have no strong feelings for one or the other</div><div><br></div><div>/Thomas</div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-04-05 16:14 GMT+02:00 Micah Cochran <span dir="ltr"><<a href="mailto:mcochran@athensal.us" target="_blank">mcochran@athensal.us</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span style="color:rgb(0,0,0);font-family:'Helvetica Neue','Segoe UI',Helvetica,Arial,'Lucida Grande',sans-serif;font-size:13px">I've submitted a pull request to move math constants (most are some version of PI) that have been used multiple places into projects.h. </span><a rel="nofollow" href="https://github.com/OSGeo/proj.4/pull/372" style="margin:0px;padding:0px;color:rgb(25,106,212);outline:none;font-family:'Helvetica Neue','Segoe UI',Helvetica,Arial,'Lucida Grande',sans-serif;font-size:13px;background-image:initial;background-repeat:initial" target="_blank">https://github.com/OSGeo/proj.4/pull/372</a><br style="color:rgb(0,0,0);font-family:'Helvetica Neue','Segoe UI',Helvetica,Arial,'Lucida Grande',sans-serif;font-size:13px"><span style="color:rgb(0,0,0);font-family:'Helvetica Neue','Segoe UI',Helvetica,Arial,'Lucida Grande',sans-serif;font-size:13px"> </span><br style="color:rgb(0,0,0);font-family:'Helvetica Neue','Segoe UI',Helvetica,Arial,'Lucida Grande',sans-serif;font-size:13px"><span style="color:rgb(0,0,0);font-family:'Helvetica Neue','Segoe UI',Helvetica,Arial,'Lucida Grande',sans-serif;font-size:13px">Also, I've renamed a few of the less obvious constants names to more obvious names. I've added psuedocode for the constants (example FORTPI is pi/4). I've did some extra testing (beyond Travis-CI test) to make fairly sure that any changes that I made did not alter the algorithms. I would be willing to add those test to proj.4.</span><br style="color:rgb(0,0,0);font-family:'Helvetica Neue','Segoe UI',Helvetica,Arial,'Lucida Grande',sans-serif;font-size:13px"><br style="color:rgb(0,0,0);font-family:'Helvetica Neue','Segoe UI',Helvetica,Arial,'Lucida Grande',sans-serif;font-size:13px"><br style="color:rgb(0,0,0);font-family:'Helvetica Neue','Segoe UI',Helvetica,Arial,'Lucida Grande',sans-serif;font-size:13px"><span style="color:rgb(0,0,0);font-family:'Helvetica Neue','Segoe UI',Helvetica,Arial,'Lucida Grande',sans-serif;font-size:13px">Please let me know if there are any issues. </span><br style="color:rgb(0,0,0);font-family:'Helvetica Neue','Segoe UI',Helvetica,Arial,'Lucida Grande',sans-serif;font-size:13px"><br style="color:rgb(0,0,0);font-family:'Helvetica Neue','Segoe UI',Helvetica,Arial,'Lucida Grande',sans-serif;font-size:13px"><br style="color:rgb(0,0,0);font-family:'Helvetica Neue','Segoe UI',Helvetica,Arial,'Lucida Grande',sans-serif;font-size:13px"><span style="color:rgb(0,0,0);font-family:'Helvetica Neue','Segoe UI',Helvetica,Arial,'Lucida Grande',sans-serif;font-size:13px">Thank you,</span><span class="HOEnZb"><font color="#888888"><br style="color:rgb(0,0,0);font-family:'Helvetica Neue','Segoe UI',Helvetica,Arial,'Lucida Grande',sans-serif;font-size:13px"><div>-- <br></div><div><div dir="ltr"><div><div dir="ltr"><p><a name="m_-3667396914425368072_UNIQUE_ID_SafeHtmlFilter_UNIQUE_ID_SafeHtmlFilter_SafeHtmlFilter__MailAutoSig"><font size="4" color="#0b5394" face="trebuchet ms, sans-serif"><b>Micah Cochran</b></font></a></p>
<p><font face="arial, helvetica, sans-serif" size="1"><span style="color:rgb(33,88,104)">GIS Coordinator - City of Athens -
Engineering Services & Community Development Dept. - Dept.
of Public Works Building - </span><a href="http://g.co/maps/ncrp7" target="_blank">1600
ELM ST W, Athens, AL </a><span style="color:rgb(33,88,104)"> - </span></font><a style="font-family:arial,helvetica,sans-serif;font-size:x-small">geo:34.820608,-86.991474</a> <span style="font-family:arial,helvetica,sans-serif;font-size:x-small;color:rgb(33,88,104)">- p.
<a href="tel:256-233-2224" value="+12562332224" target="_blank">256-233-2224</a> - f. <a href="tel:256-233-8791" value="+12562338791" target="_blank">256-233-8791</a> </span><span style="font-family:arial,helvetica,sans-serif;font-size:x-small;color:rgb(33,88,104)">-</span><span style="font-family:arial,helvetica,sans-serif;font-size:x-small;color:rgb(33,88,104)"> </span><a href="http://www.athensalabama.us" style="font-family:arial,helvetica,sans-serif;font-size:x-small" target="_blank">www.athensalabama.us</a><span style="font-family:arial,helvetica,sans-serif;font-size:x-small"> </span></p></div></div></div></div>
</font></span></div>
<br>_______________________________________________<br>
Proj mailing list<br>
<a href="mailto:Proj@lists.maptools.org">Proj@lists.maptools.org</a><br>
<a href="http://lists.maptools.org/mailman/listinfo/proj" rel="noreferrer" target="_blank">http://lists.maptools.org/mailman/listinfo/proj</a><br></blockquote></div><br></div>