[Proj] Moving Math Constants to projects.h

Thomas Knudsen knudsen.thomas at gmail.com
Tue Apr 5 14:12:11 EST 2016


Looks like a sensible thing to do, and your pseudocode/mnemonics are quite
readable.

I think I have seen (and Google confirms) that TWO_OVER_PI is in common use
for the 2/pi thing you call TWO_D_PI, but I have no strong feelings for one
or the other

/Thomas

2016-04-05 16:14 GMT+02:00 Micah Cochran <mcochran at athensal.us>:

> I've submitted a pull request to move math constants (most are some
> version of PI) that have been used multiple places into projects.h.
> https://github.com/OSGeo/proj.4/pull/372
>
> Also, I've renamed a few of the less obvious constants names to more
> obvious names.  I've added psuedocode for the constants (example FORTPI is
> pi/4).  I've did some extra testing (beyond Travis-CI test) to make fairly
> sure that any changes that I made did not alter the algorithms.  I would be
> willing to add those test to proj.4.
>
>
> Please let me know if there are any issues.
>
>
> Thank you,
> --
>
> *Micah Cochran*
>
> GIS Coordinator  -  City of Athens  -  Engineering Services & Community
> Development Dept.  -  Dept. of Public Works Building  -  1600 ELM ST W,
> Athens, AL <http://g.co/maps/ncrp7> - geo:34.820608,-86.991474 -  p.
> 256-233-2224  -  f. 256-233-8791 - www.athensalabama.us
>
> _______________________________________________
> Proj mailing list
> Proj at lists.maptools.org
> http://lists.maptools.org/mailman/listinfo/proj
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.maptools.org/pipermail/proj/attachments/20160405/342f0783/attachment.htm 


More information about the Proj mailing list